Re: Remove unused function argument
vignesh C <vignesh21@gmail.com>
From: vignesh C <vignesh21@gmail.com>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2019-10-30T05:51:59Z
Lists: pgsql-hackers
On Tue, Oct 29, 2019 at 2:51 PM Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote: > > The cache_plan argument to ri_PlanCheck has not been used since > e8c9fd5fdf768323911f7088e8287f63b513c3c6. I propose to remove it. > > That commit said "I left it alone in case there is any future need for > it" but there hasn't been a need in 7 years, and I find it confusing to > have an unused function argument without a clear purpose. It would > trivial to put it back if needed. > Code changes looks fine to me. Regards, Vignesh EnterpriseDB: http://www.enterprisedb.com
Commits
-
Remove unused function argument
- 5b7ba75f7ff8 13.0 landed
-
Allow ON UPDATE/DELETE SET DEFAULT plans to be cached.
- e8c9fd5fdf76 9.3.0 cited