Re: Handle infinite recursion in logical replication setup

vignesh C <vignesh21@gmail.com>

From: vignesh C <vignesh21@gmail.com>

To: Peter Smith <smithpb2250@gmail.com>

Cc: Amit Kapila <amit.kapila16@gmail.com>, Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>, "kuroda.hayato@fujitsu.com" <kuroda.hayato@fujitsu.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2022-06-06T05:14:08Z

Lists: pgsql-hackers

Attachments

v18-0001-Add-a-missing-test-to-verify-only-local-paramete.patch (text/x-patch) patch v18-0001
v18-0002-Skip-replication-of-non-local-data.patch (text/x-patch) patch v18-0002
v18-0003-Check-and-throw-an-error-if-publisher-tables-wer.patch (text/x-patch) patch v18-0003
v18-0004-Document-bidirectional-logical-replication-steps.patch (text/x-patch) patch v18-0004

On Fri, Jun 3, 2022 at 10:56 AM Peter Smith <smithpb2250@gmail.com> wrote:
>
> Please find below my review comments for patch v17-0001:
>
> ======
>
> 1. Commit message
> Add a missing test to verify only-local option in test_decoding plugin.
>
> "option" -> "parameter"

Modified

> ======
>
> 2. contrib/test_decoding/sql/replorigin.sql
>
> 2a.
> +-- Verify that remote origin data is not returned with only-local option
>
> SUGGESTION
> -- Verify the behaviour of the only-local parameter

Modified

> 2b.
> +-- Remote origin data returned when only-local option is not set
>
> "option" -> "parameter"

Modified

> 2c.
> +-- Remote origin data not returned when only-local option is set
>
> "option" -> "parameter"

Modified

The attached v18 patch has the fixes for the same.

Regards,
Vignesh

Commits

Improved CREATE SUBSCRIPTION message for clarity
- 1e7ca1189ccc 17.0 landed
- 842b65905046 16.0 landed
Fix the test case introduced by commit 8756930190.
- 032465157347 16.0 landed
Raise a warning if there is a possibility of data from multiple origins.
- 875693019053 16.0 landed
Add wait_for_subscription_sync for TAP tests.
- 0c20dd33db16 16.0 cited
Bump catversion for commit d8cd0c6c95c0120168df93aae095df4e0682a08a.
- 5f858dd3bebd 16.0 cited
Allow users to skip logical replication of data having origin.
- 366283961ac0 16.0 landed
Improve two comments related to a boolean DefElem's value
- 8445f5a21d40 16.0 cited
doc: Fix man page whitespace issues
- d7ab2a9a3c0a 15.0 cited