Re: Ordering of header file inclusion

vignesh C <vignesh21@gmail.com>

From: vignesh C <vignesh21@gmail.com>

To: Amit Kapila <amit.kapila16@gmail.com>

Cc: Tom Lane <tgl@sss.pgh.pa.us>, Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, Andres Freund <andres@anarazel.de>, Pg Hackers <pgsql-hackers@postgresql.org>

Date: 2019-10-21T17:34:40Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Make the order of the header file includes consistent.
- e0487223ecac 13.0 landed
Make the order of the header file includes consistent in backend modules.
- 14aec0350230 13.0 landed
Make the order of the header file includes consistent in non-backend modules.
- dddf4cdc3300 13.0 landed
Make the order of the header file includes consistent in contrib modules.
- 7e735035f208 13.0 landed

Attachments

0001-Ordering-of-header-files-in-contrib-dir-oct21.patch (application/octet-stream) patch 0001
0003-Ordering-of-header-files-remaining-dir-oct21.patch (application/octet-stream) patch 0003
0002-Ordering-of-header-files-in-backend-dir-oct21.patch (application/octet-stream) patch 0002

On Mon, Oct 21, 2019 at 8:47 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Sun, Oct 20, 2019 at 10:58 PM vignesh C <vignesh21@gmail.com> wrote:
> >
> > On Thu, Oct 17, 2019 at 4:44 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> > >
> > >
> > > I haven't reviewed it completely, but generally, the changes seem to
> > > be fine.  Please see if you can be consistent in extra space between
> > > includes.  Kindly check the same throughout the patch.
> > >
> > Thanks for reviewing the patch.
> > I have made an updated patch with comments you have suggested.
> > I have split the patch into 3 patches so that the review can be simpler.
> > This patch also includes the changes suggested by Peter & Andres.
> > I had just seen seen Tom Lane's suggestions regarding submodule header
> > file, this patch contains fix based on Andres suggestions. Let me know
> > if that need to be changed, I can update it.
> >
>
> AFAICS, none of Andres or Tom seems to be in favor of separating
> module headers.  I am also not sure if we should try to make sure of
> that in every case.
>
Thanks for the suggestions.
Updated patch contains the fix based on Tom Lane's Suggestion.
Let me know your thoughts for further revision if required.

Regards,
Vignesh
EnterpriseDB: http://www.enterprisedb.com