Re: Unused struct member in pgcrypto pgp.c

vignesh C <vignesh21@gmail.com>

From: vignesh C <vignesh21@gmail.com>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2019-07-31T05:38:11Z
Lists: pgsql-hackers
On Tue, Jul 30, 2019 at 9:19 PM Daniel Gustafsson <daniel@yesql.se> wrote:
>
> Hi,
>
> In contrib/pgcrypto/pgp.c we have a struct member int_name in digest_info which
> isn’t used, and seems to have never been used (a potential copy/pasteo from the
> cipher_info struct?).  Is there a reason for keeping this, or can it be removed
> as per the attached?
>
Agreed.
It seems the member is not being used anywhere, only code and name members
are being used in digest lookup.

Regards,
Vignesh
EnterpriseDB: http://www.enterprisedb.com



Commits

  1. Remove orphaned structure member in pgcrypto