Horton
Menu

Re: Use XLogRecPtrIsValid() instead of negated XLogRecPtrIsInvalid

vignesh C <vignesh21@gmail.com>

View thread
From: vignesh C <vignesh21@gmail.com>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: Amul Sul <sulamul@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2026-04-16T14:12:07Z
Lists: pgsql-hackers 
On Thu, 16 Apr 2026 at 19:36, Fujii Masao <masao.fujii@gmail.com> wrote:
>
> On Thu, Apr 16, 2026 at 9:31 PM Amul Sul <sulamul@gmail.com> wrote:
> > The outer parentheses do not seem to be needed, as
> > XLogRecPtrIsInvalid() already includes them.
> >
> > Other than that, the v3 patch looks good to me.
>
> I've updated the patch based on Amul's suggestion and pushed it. Thanks!

Thanks for pushing the patch.

Regards,
Vignesh

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Use XLogRecPtrIsValid() consistently for WAL position checks

  2. Use XLogRecPtrIsValid() in various places