Re: Identify missing publications from publisher while create/alter subscription.

On Tue, Sep 28, 2021 at 7:49 AM Jaime Casanova
<jcasanov@systemguards.com.ec> wrote:
>
> On Thu, Aug 26, 2021 at 07:49:49PM +0530, vignesh C wrote:
> > On Thu, Jul 15, 2021 at 5:57 PM vignesh C <vignesh21@gmail.com> wrote:
> > >
> > > On Tue, Jul 6, 2021 at 8:09 PM vignesh C <vignesh21@gmail.com> wrote:
> > > >
> > > > On Wed, Jun 30, 2021 at 8:23 PM vignesh C <vignesh21@gmail.com> wrote:
> > > > >
> > > > > On Sun, Jun 6, 2021 at 11:55 AM vignesh C <vignesh21@gmail.com> wrote:
> > > > > >
> > > > > > On Fri, May 7, 2021 at 6:44 PM vignesh C <vignesh21@gmail.com> wrote:
> > > > > > >
> > > > > > > Thanks for the comments, the attached patch has the fix for the same.
> > > > > >
> >
> > The patch was not applying on the head, attached patch which is rebased on HEAD.
> >
>
> Hi,
>
> I'm testing this patch now. It doesn't apply cleanly but is the
> documentation part, so while a rebase would be good it doesn't avoid me
> to test.

I have rebased the patch on top of Head.

> A couple of questions:
>
> +check_publications(WalReceiverConn *wrconn, List *publications,
> +                                  bool validate_publication)
> [...]
> +connect_and_check_pubs(Subscription *sub, List *publications,
> +                                          bool validate_publication)
>
> I wonder why validate_publication is passed as an argument just to
> return if it's false, why not just test it before calling those
> functions? Maybe is just a matter of style.

I felt it will be better to have the check inside function so that it
need not be checked at the multiple caller function.

> +get_publications_str(List *publications, StringInfo dest, bool quote_literal)
>
> what's the purpose of the quote_literal argument?

In case of error the publication that is not present will be displayed
within double quotes like below:
ERROR:  publications "pub3", "pub4" do not exist in the publisher
Whereas in case of the query we use single quotes, so quote_literal is
used to differentiate and handle accordingly.

Attached v12 version is rebased on top of Head.

Regards,
Vignesh