Horton
Menu

Re: Pgoutput not capturing the generated columns

vignesh C <vignesh21@gmail.com>

View thread
From: vignesh C <vignesh21@gmail.com>
To: Peter Smith <smithpb2250@gmail.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>, Shubham Khanna <khannashubham1197@gmail.com>, Masahiko Sawada <sawada.mshk@gmail.com>, Rajendra Kumar Dangwal <dangwalrajendra888@gmail.com>, pgsql-hackers@lists.postgresql.org, euler@eulerto.com
Date: 2024-11-05T05:48:41Z
Lists: pgsql-hackers 
On Tue, 5 Nov 2024 at 07:55, Peter Smith <smithpb2250@gmail.com> wrote:
>
> Hi Vignesh,
>
> Here are my review comments for the v47-0002 (DOCS) patch.
>
> ======
> diff --git a/doc/src/sgml/ddl.sgml b/doc/src/sgml/ddl.sgml
> index 577bcb4b71..a13f19bdbe 100644
> --- a/doc/src/sgml/ddl.sgml
> +++ b/doc/src/sgml/ddl.sgml
> @@ -517,7 +517,8 @@ CREATE TABLE people (
>        Generated columns are allowed to be replicated during logical replication
>        according to the <command>CREATE PUBLICATION</command> option
>        <link linkend="sql-createpublication-params-with-publish-generated-columns">
> -      <literal>include_generated_columns</literal></link>.
> +      <literal>include_generated_columns</literal></link>. See
> +      <xref linkend="logical-replication-gencols"/> for details.
>       </para>
>      </listitem>
>     </itemizedlist>
>
> Previously (in v1-0002) above there was a link to the new gencols
> section ("See XXX for details"), but in v47 that link is no longer
> included. Why not?

Included it now.

> ======
> doc/src/sgml/ref/create_publication.sgml
>
> -      lists.
> +      lists. See <xref linkend="logical-replication-gencols-howto"/> for more
> +      information on the logical replication of generated columns using a
> +      column list publication.
>       </para>
>
> I don't really think this change is necessary.
>
> The existing paragraph already says "When a column list is specified,
> only the named columns are replicated.", so there is nothing special
> more than that which we really need to say for generated columns.
>
> Also, this paragraph already has a link to the "Column List" chapter
> for more details, so if the user really wants to learn about column
> lists which happen to have generated columns in them, then that's
> where they should look. and there is a link to the new chapter 29.6
> from there.

Removed it.

The v48 version patch attached at [1] has the changes for the same.

[1] - https://www.postgresql.org/message-id/CALDaNm3Ha5t9bOLJ7OBnaMRgYHX_Q4j9k3EbRsX%3D%2B1mxUo5BZw%40mail.gmail.com

Regards,
Vignesh

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Doc: Generated column replication.

  2. Rename pubgencols_type to pubgencols in pg_publication.

  3. Doc: Fix column name in pg_publication catalog.

  4. Fix buildfarm failure introduced by commit e65dbc9927.

  5. Change publication's publish_generated_columns option type to enum.

  6. Fix \dRp+ output when describing publications with a lower server version.

  7. Replicate generated columns when 'publish_generated_columns' is set.

  8. Doc: Update the behavior of generated columns in Logical Replication.

  9. Replicate generated columns when specified in the column list.

  10. Doc: Generated columns are skipped for logical replication.