Horton

Re: [PATCH] Provide more information to filter_prepare

vignesh C <vignesh21@gmail.com>

View thread View on postgr.es
From: vignesh C <vignesh21@gmail.com>
To: Markus Wanner <markus.wanner@enterprisedb.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, Ajin Cherian <itsajin@gmail.com>
Date: 2021-03-29T13:37:58Z
Lists: pgsql-hackers 
On Mon, Mar 29, 2021 at 5:40 PM Markus Wanner
<markus.wanner@enterprisedb.com> wrote:
>
> On 29.03.21 14:00, vignesh C wrote:
> > Have you intentionally not
> > written any tests as it will be difficult to predict the xid. I just
> > wanted to confirm my understanding.
>
> Yeah, that's the reason this is hard to test this with a regression
> test.  It might be possible to come up with a TAP test for this, but I
> doubt that's worth it, as it's a pretty trivial addition.
>

Thanks, I don't have any more comments.

Regards,
Vignesh

Commits

  1. Add a xid argument to the filter_prepare callback for output plugins.