Re: Added schema level support for publication.

On Thu, Oct 7, 2021 at 12:51 PM Greg Nancarrow <gregn4422@gmail.com> wrote:
>
> On Wed, Oct 6, 2021 at 4:42 PM vignesh C <vignesh21@gmail.com> wrote:
> >
> > Attached v37 patch has the changes for the same.
> >
>
> A small issue I noticed is that using "\dS" in PSQL shows UNLOGGED
> tables as belonging to a publication, if the table belongs to a schema
> that was added to the publication using ALL TABLES IN SCHEMA (yet
> doesn't show as part of an ALL TABLES publication).
> Since publication of UNLOGGED tables is silently skipped in the case
> of ALL TABLES and ALL TABLES IN SCHEMA, it shouldn't show as belonging
> to the publication, right?
>
> test=# \dRp+ pub2
>                             Publication pub2
>  Owner | All tables | Inserts | Updates | Deletes | Truncates | Via root
> -------+------------+---------+---------+---------+-----------+----------
>  gregn | t          | t       | t       | t       | t         | f
> (1 row)
>
> test=# \dRp+ pub
>                              Publication pub
>  Owner | All tables | Inserts | Updates | Deletes | Truncates | Via root
> -------+------------+---------+---------+---------+-----------+----------
>  gregn | f          | t       | t       | t       | t         | t
> Tables from schemas:
>     "sch1"
>
> test=# \dS sch1.test2
>             Unlogged table "sch1.test2"
>  Column |  Type   | Collation | Nullable | Default
> --------+---------+-----------+----------+---------
>  i      | integer |           |          |
> Publications:
>     "pub"

Thanks for reporting the issue. The attached patch has the fix for the issue.

Regards,
Vignesh