Re: Option to dump foreign data in pg_dump

Hi Luis,
Here is a few comment for me

*I suggest the option to be just –foreign-data because if we make it
–include-foreign-data its expected to have –exclude-foreign-data option
too.

*please add test case

* + if (tdinfo->filtercond || tbinfo->relkind == RELKIND_FOREIGN_TABLE)

filter condition is not implemented completely yet so the logic only work
on foreign table so I think its better to handle it separately

* I don’t understand the need for changing SELECT query .we can use the
same SELECT query syntax for both regular table and foreign table


regards

Surafel