Horton

Re: pg_dump multi VALUES INSERT

Surafel Temsgen <surafel3000@gmail.com>

View thread View on postgr.es
From: Surafel Temesgen <surafel3000@gmail.com>
To: alvherre@2ndquadrant.com
Cc: coelho@cri.ensmp.fr, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2018-11-08T13:02:24Z
Lists: pgsql-hackers

Attachments

On Tue, Nov 6, 2018 at 8:18 PM Alvaro Herrera <alvherre@2ndquadrant.com>
wrote:

> On 2018-Nov-06, Surafel Temesgen wrote:
>
> > hi,
> >
> > On Sun, Nov 4, 2018 at 1:18 PM Fabien COELHO <coelho@cri.ensmp.fr>
> wrote:
> >
> > > Patch does not seem to apply anymore, could you rebase?
> > >
> > The attached patch is a rebased version and work by ‘inserts=100’ as
> > Stephen suggest
>
> I thought the suggestion was that the number could be any positive
> integer, not hardcoded 100.

ok

> It shouldn't take much more code to handle
> it that way, which makes more sense to me
>

yes its not much line of code. Attach is a patch that optionally accept the
number of row in a single insert statement and if it is not specified one
row per statement used

regards

Surafel

Commits

  1. Add pg_dumpall --rows-per-insert

  2. pg_dump: allow multiple rows per insert