Horton

Thread

Commits

  1. Remove -o/--oids from pg_dumpall

  2. Remove WITH OIDS support, change oid catalog column visibility.

  1. with oids option not removed in pg_dumpall

    Surafel Temsgen <surafel3000@gmail.com> — 2019-05-21T06:31:48Z

    Hello,
Commit 578b229718e8f remove oids option from pg_dump but its is
still in pg_dumpall .The attach patch remove it
regards
Surafel

  2. Re: with oids option not removed in pg_dumpall

    Michael Paquier <michael@paquier.xyz> — 2019-05-21T08:24:57Z

    On Tue, May 21, 2019 at 09:31:48AM +0300, Surafel Temesgen wrote:
> Commit 578b229718e8f remove oids option from pg_dump but its is
> still in pg_dumpall .The attach patch remove it

Good catch.  Your cleanup looks correct to me.  Andres, perhaps you
would prefer doing the cleanup yourself?
--
Michael

  3. Re: with oids option not removed in pg_dumpall

    Michael Paquier <michael@paquier.xyz> — 2019-05-23T00:42:55Z

    On Tue, May 21, 2019 at 05:24:57PM +0900, Michael Paquier wrote:
> Good catch.  Your cleanup looks correct to me.  Andres, perhaps you
> would prefer doing the cleanup yourself?

As I am cleaning up the area for another issue, applied.
--
Michael

  4. Re: with oids option not removed in pg_dumpall

    Surafel Temsgen <surafel3000@gmail.com> — 2019-05-23T13:26:38Z

    Thank you for applying

regards
Surafel

On Thu, May 23, 2019 at 3:43 AM Michael Paquier <michael@paquier.xyz> wrote:

> On Tue, May 21, 2019 at 05:24:57PM +0900, Michael Paquier wrote:
> > Good catch.  Your cleanup looks correct to me.  Andres, perhaps you
> > would prefer doing the cleanup yourself?
>
> As I am cleaning up the area for another issue, applied.
> --
> Michael
>

  5. Re: with oids option not removed in pg_dumpall

    Andres Freund <andres@anarazel.de> — 2019-05-23T15:55:47Z

    Hi,

On 2019-05-23 16:26:38 +0300, Surafel Temesgen wrote:
> Thank you for applying
> 
> regards
> Surafel
> 
> On Thu, May 23, 2019 at 3:43 AM Michael Paquier <michael@paquier.xyz> wrote:
> 
> > On Tue, May 21, 2019 at 05:24:57PM +0900, Michael Paquier wrote:
> > > Good catch.  Your cleanup looks correct to me.  Andres, perhaps you
> > > would prefer doing the cleanup yourself?
> >
> > As I am cleaning up the area for another issue, applied.

Thanks for finding and applying.

Greetings,

Andres Freund