Horton

Re: Problem with synchronous replication

Dongming Liu <ldming101@gmail.com>

View thread View on postgr.es
From: Dongming Liu <ldming101@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2019-10-30T04:22:12Z
Lists: pgsql-hackers 
On Wed, Oct 30, 2019 at 9:12 AM Michael Paquier <michael@paquier.xyz> wrote:

> On Tue, Oct 29, 2019 at 01:40:41PM +0800, Dongming Liu wrote:
> > Can someone help me to confirm that these two problems are bugs?
> > If they are bugs, please help review the patch or provide better fix
> > suggestions.
>
> There is no need to send periodic pings.  Sometimes it takes time to
> get replies as time is an important resource that is always limited.
>

 Thank you for your reply. I also realized my mistake, thank you for
correcting me.


> I can see that Horiguchi-san has already provided some feedback, and I
> am looking now at your suggestions.
>

Thanks again.

Commits

  1. Add some assertions in syncrep.c

  2. Fix race condition at backend exit when deleting element in syncrep queue

  3. Fix typo in comment of syncrep.c