Horton

Re: Catalog_xmin is not advanced when a logical slot is lost

sirisha chamarthi <sirichamarthi22@gmail.com>

View thread View on postgr.es
From: sirisha chamarthi <sirichamarthi22@gmail.com>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>, pgsql-hackers@lists.postgresql.org, Amit Kapila <amit.kapila16@gmail.com>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Date: 2022-11-21T15:18:09Z
Lists: pgsql-hackers

Attachments

Thanks Alvaro,  Ashutosh  for your comments.

On Mon, Nov 21, 2022 at 6:20 AM Alvaro Herrera <alvherre@alvh.no-ip.org>
wrote:

> On 2022-Nov-21, Ashutosh Bapat wrote:
>
> > Maybe. In that case pg_get_replication_slots() should be changed. We
> > should use the same criteria to decide whether a slot is invalidated
> > or not at all the places.
>
> Right.
>

Agreed.


>
> > I am a fan of stricter, all-assumption-covering conditions. In case we
> > don't want to check restart_lsn, an Assert might be useful to validate
> > our assumption.
>
> Agreed.  I'll throw in an assert.
>

Changed this in the patch to throw an assert.


> --
> Álvaro Herrera         PostgreSQL Developer  —
> https://www.EnterpriseDB.com/
>

Commits

  1. Ignore invalidated slots while computing oldest catalog Xmin