Horton

Re: Fix comments atop pg_get_replication_slots

sirisha chamarthi <sirichamarthi22@gmail.com>

View thread View on postgr.es
From: sirisha chamarthi <sirichamarthi22@gmail.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2022-11-21T07:52:59Z
Lists: pgsql-hackers

Attachments

Amit, thanks for looking into this!

On Sun, Nov 20, 2022 at 11:38 PM Amit Kapila <amit.kapila16@gmail.com>
wrote:

> On Mon, Nov 21, 2022 at 12:45 PM sirisha chamarthi
> <sirichamarthi22@gmail.com> wrote:
> >
> > Hi Hackers,
> >
> > The comments atop seem to indicate that it is only showing active
> replication slots. The comment is ambiguous as it also shows all the slots
> including lost and inactive slots. Attached a small patch to fix it.
> >
>
> I agree that it is a bit confusing. How about "SQL SRF showing all
> replication slots that currently exist on the database cluster"?
>

Looks good to me. Attached a patch for the same.


>
> --
> With Regards,
> Amit Kapila.
>

Commits

  1. Improve comments atop pg_get_replication_slots.