Re: IDLE in transaction introspection

Scott Mead <scottm@openscg.com>

From: Scott Mead <scottm@openscg.com>

To: Albe Laurenz <laurenz.albe@wien.gv.at>

Cc: "Andrew Dunstan *EXTERN*" <andrew@dunslane.net>, Tom Lane <tgl@sss.pgh.pa.us>, Simon Riggs <simon@2ndquadrant.com>, Robert Haas <robertmhaas@gmail.com>, Magnus Hagander <magnus@hagander.net>, pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2011-11-02T18:18:57Z

Lists: pgsql-hackers

Attachments

pg_stat_activity_state_query.patch (application/octet-stream) patch

On Wed, Nov 2, 2011 at 4:12 AM, Albe Laurenz <laurenz.albe@wien.gv.at>wrote:

> Andrew Dunstan wrote:
> > On 11/01/2011 09:52 AM, Tom Lane wrote:
> >> I'm for just redefining the query field as "current or last
> >> query".
> >
> > +1
> >
> >> I could go either way on whether to rename it.
> >
> > Rename it please. "current_query" will just be wrong. I'd be inclined
> > just to call it "query" or "query_string" and leave it to the docs to
> > define the exact semantics.
>
> +1 for renaming, +1 for a state column.
> I think it is overkill to keep a query history beyond that -- if you
> want that,
> you can resort to the log files.
>
>
ISTM that we're all for:

   creating a new column: state
   renaming current_query => query

   State will display <RUNNING>, <IDLE>, <IDLE> in transaction, etc...
   query will display the last query that was executed.

I've written this up in the attached patch, looking for feedback. (NB:
Originally I was using 9.1.1 release, I just did a git clone today to
generate this).

--
  Scott Mead
   OpenSCG http://www.openscg.com

> Yours,
> Laurenz Albe
>