Re: Adding support for SSLKEYLOGFILE in the frontend

Abhishek Chanda <abhishek.becs@gmail.com>

From: Abhishek Chanda <abhishek.becs@gmail.com>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Jacob Champion <jacob.champion@enterprisedb.com>, Tom Lane <tgl@sss.pgh.pa.us>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2025-01-10T23:16:44Z
Lists: pgsql-hackers

Attachments

Thanks, Daniel. Here is an updated patch with all previous changes,
added a simple connection test and another check to make sure file
mode is correct, and the env var fix. Please let me know if anything
needs to be changed. I tested this locally using meson running all TAP
tests, and also manually.

Thanks
Abhishek

On Fri, Jan 10, 2025 at 9:29 AM Daniel Gustafsson <daniel@yesql.se> wrote:
>
> > On 10 Jan 2025, at 04:59, Abhishek Chanda <abhishek.becs@gmail.com> wrote:
>
> Thanks for the new version.
>
> +       {"sslkeylogfile", "SSLKEYLOGFILE",
> The env var should be PGSSLKEYLOGFILE with the PG prefix.
>
> > 3. Added docs and tests
>
> There is no test in the attached patch, did you write one but forgot to git add
> it before committing locally?
>
> --
> Daniel Gustafsson
>


-- 
Thanks and regards
Abhishek Chanda

Commits

  1. Fix sslkeylogfile error handling logging

  2. Mark sslkeylogfile as Debug option

  3. libpq: Add support for dumping SSL key material to file