Re: Adding error messages to a few slash commands
Abhishek Chanda <abhishek.becs@gmail.com>
From: Abhishek Chanda <abhishek.becs@gmail.com>
To: Pavel Luzanov <p.luzanov@postgrespro.ru>
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2025-04-13T16:40:29Z
Lists: pgsql-hackers
Attachments
- v2-0001-Print-empty-table-when-a-given-object-is-not-foun.patch (application/octet-stream) patch v2-0001
Thanks for the feedback, attached an updated patch that changes most of those "Did not find" messages to empty tables. I did not change two sets, listDbRoleSettings and listTables both have comments describing that these are deliberately this way. I wanted to post this update to close this loop for now. I will follow up once the merge window opens again. Thanks On Sun, Apr 13, 2025 at 1:47 AM Pavel Luzanov <p.luzanov@postgrespro.ru> wrote: > > On 13.04.2025 08:29, Tom Lane wrote: > > Abhishek Chanda <abhishek.becs@gmail.com> writes: > > Currently, some slash commands in psql return an error saying "Did not > find any XXXX named YYYY" while some return an empty table. This patch > changes a few of the slash commands to return a similar error message. > > > +1 for this patch. > > Personally, if I were trying to make these things consistent, I'd have > gone in the other direction (ie return empty tables). > > > +1 > Returning empty tables is a more appropriate behavior. > > -- > Pavel Luzanov > Postgres Professional: https://postgrespro.com -- Thanks and regards Abhishek Chanda