Horton

Re: Autovacuum on partitioned table (autoanalyze)

yuzuko <yuzukohosoya@gmail.com>

View thread View on postgr.es
From: yuzuko <yuzukohosoya@gmail.com>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Justin Pryzby <pryzby@telsasoft.com>, Amit Langote <amitlangote09@gmail.com>, Alvaro Herrera <alvherre@2ndquadrant.com>, Masahiko Sawada <masahiko.sawada@2ndquadrant.com>, Laurenz Albe <laurenz.albe@cybertec.at>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Greg Stark <stark@mit.edu>
Date: 2020-08-17T06:11:28Z
Lists: pgsql-hackers

Attachments

I'm sorry for the late reply.

> This version seems to fail under Werror which is used in the Travis builds:
>
> autovacuum.c: In function ‘relation_needs_vacanalyze’:
> autovacuum.c:3117:59: error: ‘reltuples’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
>    anlthresh = (float4) anl_base_thresh + anl_scale_factor * reltuples;
>                                                            ^
> autovacuum.c:2972:9: note: ‘reltuples’ was declared here
>   float4  reltuples;  /* pg_class.reltuples */
>          ^
>

I attach the latest patch that solves the above Werror.
Could you please check it again?

-- 
Best regards,
Yuzuko Hosoya
NTT Open Source Software Center

Commits

  1. Keep stats up to date for partitioned tables

  2. Revert analyze support for partitioned tables

  3. Document ANALYZE storage parameters for partitioned tables

  4. autovacuum: handle analyze for partitioned tables