Horton

Re: BUG #15844: MIPS: remove .set mips2 in s_lock.h to fix r6 build

YunQiang Su <wzssyqa@gmail.com>

View thread View on postgr.es
From: YunQiang Su <wzssyqa@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-bugs@lists.postgresql.org
Date: 2019-06-11T05:12:54Z
Lists: pgsql-bugs 
Michael Paquier <michael@paquier.xyz> 于2019年6月11日周二 下午12:57写道：
>
> On Tue, Jun 11, 2019 at 04:39:35AM +0000, PG Bug reporting form wrote:
> > MIPS r6 changes the encoding of LL/SC instruction,
> > while the .set mips2 will force assembler to generate
> > old encoding.
>
> This is quite architecture-specific.  May I suggest to add this patch
> to the follow-up commit fest for awareness:
> https://commitfest.postgresql.org/23/
>
> Do you have any references, like documentation, which summarize that?

https://s3-eu-west-1.amazonaws.com/downloads-mips/documents/MD00087-2B-MIPS64BIS-AFP-6.06.pdf
The page: 307

> --
> Michael



-- 
YunQiang Su

Commits

  1. Fix spinlock assembly code for MIPS so it works on MIPS r6.