Re: Draft for basic NUMA observability

Jakub Wartak <jakub.wartak@enterprisedb.com>

View thread

From: Jakub Wartak <jakub.wartak@enterprisedb.com>

To: Andres Freund <andres@anarazel.de>

Cc: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>

Date: 2025-02-26T13:05:59Z

Lists: pgsql-hackers

Attachments

v5-0002-Extend-pg_buffercache-with-new-view-pg_buffercach.patch (application/octet-stream) patch v5-0002
v5-0001-Add-optional-dependency-to-libnuma-for-basic-NUMA.patch (application/octet-stream) patch v5-0001
v5-0003-Add-pg_shmem_numa_allocations.patch (application/octet-stream) patch v5-0003

On Wed, Feb 26, 2025 at 10:58 AM Andres Freund <andres@anarazel.de> wrote:
>
> Hi,
>
> On 2025-02-26 09:38:20 +0100, Jakub Wartak wrote:
> > > FWIW, what you posted fails on CI:
> > > https://cirrus-ci.com/task/5114213770723328
> > >
> > > Probably some ifdefs are missing. The sanity-check task configures with
> > > minimal dependencies, which is why you're seeing this even on linux.
> >
> > Hopefully fixed, we'll see what cfbot tells, I'm flying blind with all
> > of this CI stuff...
>
> FYI, you can enable CI on a github repo, to see results without posting to the
> list:
> https://github.com/postgres/postgres/blob/master/src/tools/ci/README

Thanks, I'll take a look into it.

Meanwhile v5 is attached with slight changes to try to make cfbot happy:
1. fixed tests and added tiny copy-cat basic tests for
pg_buffercache_numa and pg_shm_numa_allocations views
2. win32 doesn't have sysconf()

No docs yet.

-J.

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

doc: Correct pg_shmem_allocations_numa.size data type
- b8a6078ca8f4 18.0 landed
Add pg_buffercache_numa view with NUMA node info
- ba2a3c2302f1 18.0 landed
Add support for basic NUMA awareness
- 65c298f61fc7 18.0 landed
Introduce pg_shmem_allocations_numa view
- 8cc139bec34a 18.0 landed