Re: Draft for basic NUMA observability

Jakub Wartak <jakub.wartak@enterprisedb.com>

View thread

From: Jakub Wartak <jakub.wartak@enterprisedb.com>

To: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>

Cc: Andres Freund <andres@anarazel.de>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>

Date: 2025-03-07T10:20:03Z

Lists: pgsql-hackers

Attachments

v8-0002-Extend-pg_buffercache-with-new-view-pg_buffercach.patch (application/octet-stream) patch v8-0002
v8-0003-Add-pg_shmem_numa_allocations-to-show-NUMA-zones-.patch (application/octet-stream) patch v8-0003
v8-0001-Add-optional-dependency-to-libnuma-Linux-only-for.patch (application/octet-stream) patch v8-0001

Hi,
On Wed, Mar 5, 2025 at 10:30 AM Jakub Wartak
<jakub.wartak@enterprisedb.com> wrote:
>Hi,

> > Yeah, that's why I was mentioning to use a "shared" populate_buffercache_entry()
> > or such function: to put the "duplicated" code in it and then use this
> > shared function in pg_buffercache_pages() and in the new numa related one.
>
> OK, so hastily attempted that in 7b , I had to do a larger refactor
> there to avoid code duplication between those two. I don't know which
> attempt is better though (7 vs 7b)..
>

I'm attaching basically the earlier stuff (v7b) as v8 with the
following minor changes:
- docs are included
- changed int8 to int4 in one function definition for numa_zone_id

-J.

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

doc: Correct pg_shmem_allocations_numa.size data type
- b8a6078ca8f4 18.0 landed
Add pg_buffercache_numa view with NUMA node info
- ba2a3c2302f1 18.0 landed
Add support for basic NUMA awareness
- 65c298f61fc7 18.0 landed
Introduce pg_shmem_allocations_numa view
- 8cc139bec34a 18.0 landed