Re: Add errdetail() with PID and UID about source of termination signal
Jakub Wartak <jakub.wartak@enterprisedb.com>
From: Jakub Wartak <jakub.wartak@enterprisedb.com>
To: Chao Li <li.evan.chao@gmail.com>
Cc: Jim Jones <jim.jones@uni-muenster.de>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2026-02-24T10:05:29Z
Lists: pgsql-hackers
Attachments
- v2-0001-Add-errdetail-with-PID-and-UID-about-source-of-te.patch (text/x-patch) patch v2-0001
On Tue, Feb 24, 2026 at 9:40 AM Chao Li <li.evan.chao@gmail.com> wrote: [..] > There is guidance in the documentation regarding error message style: https://www.postgresql.org/docs/current/error-style-guide.html > ``` > Detail and hint messages: Use complete sentences, and end each with a period. Capitalize the first word of sentences. Put two spaces after the period if another sentence follows (for English text; might be inappropriate in other languages). > ``` > > I also noticed that some existing DETAIL and HINT messages do not fully follow this guideline. But I believe new code should adhere to the documented style as much as possible. In particular, DETAIL and HINT messages should begin with a capital letter and follow the complete-sentence convention. Hi, v2 attached, WIP, the only known remaining issue to me is that windows might fail to compile as it probably doesn't have concept of uid_t... I'm wondering what to do there. 1. Rebased due to recent change to remove bgwriter_die() 2. Added auto-detection of SA_SIGINFO to meson and autoconf 3. Changed "Signal" to be in upper case now (I don't like it, but it follows guideline now) 4. Tested on FreeBSD 14.3 - it works there too now.. 5. ...and fixed some clang warnings by changing %d -> %lld in errdetail due to apparent pid_t differences on platforms. -J.
Commits
Same data as JSON:
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Only show signal-sender PID/UID detail in server log
- b772f3fcad18 19 (unreleased) landed
-
Make psql DETAIL line test unconditionally optional.
- 446c400fd89b 19 (unreleased) landed
-
Rework signal handler infrastructure to pass sender info as argument.
- 3e2a1496bae6 19 (unreleased) landed
-
Add errdetail() with PID and UID about source of termination signal.
- 55890a919454 19 (unreleased) landed