Horton

Re: RFC: split OBJS lines to one object per line

Mahendra Singh Thalor <mahi6run@gmail.com>

View thread View on postgr.es
From: Mahendra Singh <mahi6run@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Andres Freund <andres@anarazel.de>, Peter Geoghegan <pg@bowt.ie>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2019-12-18T03:00:24Z
Lists: pgsql-hackers 
On Wed, 18 Dec 2019 at 07:23, Michael Paquier <michael@paquier.xyz> wrote:
>
> On Tue, Dec 17, 2019 at 11:40:17PM +0530, Mahendra Singh wrote:
> > I found some inconsistency in alphabetical order in
> > src/backend/tsearch/Makefile, src/backend/utils/Makefile and
> > src/pl/plpython/Makefile files.  Attached patch is fixing those order
> > related inconsistency.
>
> Thanks, committed.  The one-liner style is also used in ifaddrs, but

Thanks Michael for quick response.

> fmgrtab.c is generated so I have left that out.  Now, have you tried
> to compile plpython before sending this patch?  Because as you forgot
> to add one backslash after WIN32RES, compilation was failing there.
> And you also forgot to remove two backslashes at the end of the other
> two lists modified :)

Sorry, I forgot to add backslashes. I will take care from next time.

Thanks and Regards
Mahendra Thalor
EnterpriseDB: http://www.enterprisedb.com

Commits

  1. Fix some OBJS lists in two Makefiles to be ordered alphabetically

  2. Split all OBJS style lines in makefiles into one-line-per-entry style.