Re: as per commit 643a1a61985bef2590496, move create/open dir code to function using switch case of pg_backup_directory.c file also

Mahendra Singh Thalor <mahi6run@gmail.com>

From: Mahendra Singh Thalor <mahi6run@gmail.com>

To: Andrew Dunstan <andrew@dunslane.net>

Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2025-04-07T18:59:06Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Further cleanup for directory creation on pg_dump/pg_dumpall
- 4170298b6ecf 18.0 landed

Attachments

v02_move-create-dir-code-to-the-switch-in-pg_backup_dir.patch (application/octet-stream) patch v2

On Mon, 7 Apr 2025 at 18:52, Andrew Dunstan <andrew@dunslane.net> wrote:
>
>
> On 2025-04-07 Mo 8:25 AM, Mahendra Singh Thalor wrote:
> > Hi,
> > In commit 643a1a61985bef2590496, we did some cleanup and we replaced
> > if-else with switch case.
> > Basically, we made a function to open a directory in pg_dumpall.
> > In pg_backup_directory.c file also, we are opening a directory with
> > if-else.
> > Here, I am attaching a patch which makes both the files similar.
> >
> > We can move this similar function into one common file also but as of
> > now, I made a static function same as pg_dumpall.c.
>
>
> Yeah, let's put it in a common file. There's no point in duplicating it.

Thanks Andrew.

I moved this common function dumputils.c file. Here, I am attaching a
patch for the same.


-- 
Thanks and Regards
Mahendra Singh Thalor
EnterpriseDB: http://www.enterprisedb.com