Re: bug: pg_dumpall with --data-only and --clean options is giving an error after some dump
Mahendra Singh Thalor <mahi6run@gmail.com>
From: Mahendra Singh Thalor <mahi6run@gmail.com>
To: Álvaro Herrera <alvherre@kurilemu.de>
Cc: Andrew Dunstan <andrew@dunslane.net>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2026-03-15T14:06:14Z
Lists: pgsql-hackers
Attachments
- v02-master-pg_dumpall-clean-and-data-only-are-incompatible.patch (text/x-patch) patch v2
- v02-PG18-pg_dumpall-clean-and-data-only-are-incompatible.noci (application/octet-stream)
- v02-PG14-pg_dumpall-clean-and-data-only-are-incompatible.noci (application/octet-stream)
- v02-PG15-16-17-pg_dumpall-clean-and-data-only-are-incompatible.noci (application/octet-stream)
Thanks Andrew, Álvaro and Srinath for the review and feedback. > 1) maybe match the pg_dumpall comment with the pg_dump comment. I took this comment from pg_restore so i am keeping this same as pg_restore. > 2) please fix the indentation using pgindent > -- > Thanks, > Srinath Reddy Sadipiralla > EDB: https://www.enterprisedb.com/ Fixed. On Sun, 15 Mar 2026 at 17:41, Álvaro Herrera <alvherre@kurilemu.de> wrote: > > Hi, > > On 2026-Mar-15, Andrew Dunstan wrote: > > > On 2026-03-14 Sa 3:18 PM, Mahendra Singh Thalor wrote: > > > > > I was doing some tests with pg_dump, pg_dumpall and pg_restore tools. > > > With "pg_dumpall --data-only --clean", we are reporting an error after > > > dumping some data. > > > > Hmm, this looks like behaviour that goes a long way back. Should we > > backpatch this fix? > > IMO it would make sense to do so. > > -- > Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/ As per suggestions, I made patches till PG14. Here, I am attaching updated patches. -- Thanks and Regards Mahendra Singh Thalor EnterpriseDB: http://www.enterprisedb.com
Commits
-
pg_dumpall: Fix handling of incompatible options.
- be0d0b457cb6 19 (unreleased) landed