Re: Crash in add_paths_to_append_rel
Andy Fan <zhihui.fan1213@gmail.com>
From: Andy Fan <zhihui.fan1213@gmail.com>
To: David Rowley <dgrowleyml@gmail.com>
Cc: Richard Guo <guofenglinux@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2023-10-10T04:48:17Z
Lists: pgsql-hackers
On Tue, Oct 10, 2023 at 11:52 AM David Rowley <dgrowleyml@gmail.com> wrote: > On Mon, 9 Oct 2023 at 22:49, Richard Guo <guofenglinux@gmail.com> wrote: > > I came across a crash in add_paths_to_append_rel() with the query below. > > > It was introduced by commit a8a968a8 where we referenced > > cheapest_startup_path->param_info without first checking that we have a > > valid cheapest_startup_path. > > I pushed this with just minor adjustments to the comments you wrote. I > didn't feel the need to reiterate on the set_cheapest() comments. > > Thanks Richard for the report and also Thanks you David for the push! -- Best Regards Andy Fan
Commits
-
Fix possible crash in add_paths_to_append_rel()
- fc4089f3c65a 17.0 landed
-
Consider cheap startup paths in add_paths_to_append_rel
- a8a968a8212e 17.0 cited