Horton
Menu

Re: Extract numeric [field] in JSONB more effectively

Andy Fan <zhihui.fan1213@gmail.com>

View thread
From: Andy Fan <zhihui.fan1213@gmail.com>
To: Chapman Flack <chap@anastigmatix.net>
Cc: jian he <jian.universality@gmail.com>, Pavel Stehule <pavel.stehule@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2023-08-10T08:03:15Z
Lists: pgsql-hackers

Attachments

Hi Chap:

  Thanks for the review.


> The minor spelling point, the word 'field' has been spelled
> 'filed' throughout this comment (just as in the email subject):
>
> +               /*
> +                * Simplify cast(jsonb_object_filed(jsonb, filedName) as
> type)
> +                * to jsonb_object_field_type(jsonb, filedName,
> targetTypeOid);
> +                */
>
>
Thanks for catching this, fixed in v5.


> The question: the simplification is currently being applied
> when the underlying operation uses F_JSONB_OBJECT_FIELD.
> Are there opportunities for a similar benefit if applied
> over F_JSONB_ARRAY_ELEMENT and/or F_JSONB_EXTRACT_PATH?
>

Yes, we do have similar opportunities for both functions.  v5 attached for
this.

-- 
Best Regards
Andy Fan

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Add trailing commas to enum definitions