Horton

Re: [PATCH] Add pg_get_tablespace_ddl() function to reconstruct CREATE TABLESPACE statement

Manni Wood <manni.wood@enterprisedb.com>

View thread
From: Manni Wood <manni.wood@enterprisedb.com>
To: Jim Jones <jim.jones@uni-muenster.de>
Cc: Nishant Sharma <nishant.sharma@enterprisedb.com>, Álvaro Herrera <alvherre@kurilemu.de>, pgsql-hackers@postgresql.org
Date: 2025-11-07T22:38:32Z
Lists: pgsql-hackers

Attachments

On Fri, Nov 7, 2025 at 10:16 AM Jim Jones <jim.jones@uni-muenster.de> wrote:

>
>
> On 07/11/2025 02:27, Manni Wood wrote:
> > Attached v7 fixes problems in tests due to whitespace.
>
>
> Since get_tablespace_loc_string returns a palloc'd string, I guess you
> could pfree it after the if block. The same applies for spcowner, since
> you're calling GetUserNameFromId() with noerr = false.
>
> For reference, see pg_get_indexdef_worker():
>
> ...
> /*
>  * If it has options, append "WITH (options)"
>  */
> str = flatten_reloptions(indexrelid);
> if (str)
> {
>   appendStringInfo(&buf, " WITH (%s)", str);
>   pfree(str);
> }
> ...
>
>
> Thanks
>
> Best, Jim
>

Hello, Álvaro and Jim!

I have incorporated both of your suggestions into this pair of v8 patches.

Let me know what you think.
-- 
-- Manni Wood EDB: https://www.enterprisedb.com