Thread

Re: [PATCH] Add pg_get_tablespace_ddl() function to reconstruct CREATE TABLESPACE statement

Manni Wood <manni.wood@enterprisedb.com> — 2025-11-08T14:05:49Z

On Fri, Nov 7, 2025 at 10:46 PM Manni Wood <manni.wood@enterprisedb.com>
wrote:

>
>
> On Fri, Nov 7, 2025 at 10:19 PM Manni Wood <manni.wood@enterprisedb.com>
> wrote:
>
>>
>>
>> On Fri, Nov 7, 2025 at 6:03 PM Jim Jones <jim.jones@uni-muenster.de>
>> wrote:
>>
>>>
>>>
>>> On 08/11/2025 00:38, Manni Wood wrote:
>>> > Alas, the build https://commitfest.postgresql.org/patch/6175/
>>> <https://
>>> > commitfest.postgresql.org/patch/6175/> now fails, and I cannot
>>> reproduce
>>> > on my machine. Obviously there will be a v9...
>>>
>>> You forgot the declaration for build_tablespace_ddl_string[1]:
>>>
>>> ruleutils.c:13755:1: warning: no previous prototype for
>>> ‘build_tablespace_ddl_string’ [-Wmissing-prototypes]
>>> 13755 | build_tablespace_ddl_string(const Oid tspaceoid)
>>>       | ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>>>
>>> Best, Jim
>>>
>>> 1 - https://cirrus-ci.com/task/4855404196265984?logs=build#L1911
>>>
>>>
>> Thank you very much, Jim. Serves me right for looking at the error at the
>> end of the logs rather than the warning in the middle.
>>
>> v9 is attached.
>> --
>> -- Manni Wood EDB: https://www.enterprisedb.com
>>
>
> Ah, the error at the end of the logs is indeed still happening. Glad to
> have gotten rid of that earlier warning, though.
>
> https://cirrus-ci.com/task/6437176629526528?logs=build#L1906-L1912
>
> I will ask for Nishant's help with this and post another patch.
> --
> -- Manni Wood EDB: https://www.enterprisedb.com
>

Apologies for the noise. Just wanted to confirm that I did a fresh clone of
github.com/postgres/postgres on my linux machine, applied both v9 patches
to master, ran
"configure", "make world", "make check-world", and everything passed.

However, I see that this
https://cirrus-ci.com/task/6437176629526528?logs=clone#L214 checks out a
specific commit on a specific branch:

"Checked out db131410131cb6a60f074213b0e7aaaa15d72f87 on cf/6175 branch."

My clone of postgres (which is presumably shallow?) does not show that
branch, not even with "git branch -r".

Thanks very much, all, for your patience.
-- 
-- Manni Wood EDB: https://www.enterprisedb.com