Horton

Re: [PATCH] Add pg_get_tablespace_ddl() function to reconstruct CREATE TABLESPACE statement

Manni Wood <manni.wood@enterprisedb.com>

View thread
From: Manni Wood <manni.wood@enterprisedb.com>
To: Nishant Sharma <nishant.sharma@enterprisedb.com>
Cc: Álvaro Herrera <alvherre@kurilemu.de>, Jim Jones <jim.jones@uni-muenster.de>, pgsql-hackers@postgresql.org
Date: 2025-11-06T22:08:11Z
Lists: pgsql-hackers

Attachments

On Wed, Nov 5, 2025 at 5:54 AM Nishant Sharma <
nishant.sharma@enterprisedb.com> wrote:

> Thanks Álvaro for the review comments on v4!
>
> PFA, v5 patch set. I have included all your review comments.
>
>
> Regards,
> Nishant Sharma.
> EDB, Pune.
> https://www.enterprisedb.com
>

The BSD build was failing with the error 'WARNING:  tablespaces created by
regression test cases should have names starting with "regress_"', so the
attached patches should fix that.

The windows build is also failing, on this error
"../src/port/strerror.c(311): fatal error C1051: program database file,
'C:\cirrus\build\src\port\libpgport_srv.pdb', has an obsolete format,
delete it and recompile", which I don't think is related to our patch.
-- 
-- Manni Wood EDB: https://www.enterprisedb.com