Re: brininsert optimization opportunity

Ashwin Agrawal <ashwinstar@gmail.com>

From: Ashwin Agrawal <ashwinstar@gmail.com>
To: Tomas Vondra <tomas.vondra@enterprisedb.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, Matthias van de Meent <boekewurm+postgres@gmail.com>, Soumyadeep Chakraborty <soumyadeep2007@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2023-11-25T22:33:52Z
Lists: pgsql-hackers
On Sat, Nov 25, 2023 at 12:06 PM Tomas Vondra <tomas.vondra@enterprisedb.com>
wrote:

> I've done a bit more cleanup on the last version of the patch (renamed
> the fields to start with bis_ as agreed, rephrased the comments / docs /
> commit message a bit) and pushed.


Thanks a lot Tomas for helping to drive the patch to completion iteratively
and realizing the benefits.

- Ashwin

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →
  1. Add missing index_insert_cleanup calls

  2. Fix a couple typos in BRIN code

  3. Check if ii_AmCache is NULL in aminsertcleanup

  4. Use fipshash in brin_multi test

  5. Reuse BrinDesc and BrinRevmap in brininsert

  6. Consider fillfactor when estimating relation size

  7. Postpone some stuff out of ExecInitModifyTable.