Re: Eval expression R/O once time (src/backend/executor/execExpr.c)

Artur Zakirov <zaartur@gmail.com>

From: Artur Zakirov <zaartur@gmail.com>

To: Ranier Vilela <ranier.vf@gmail.com>

Cc: Tom Lane <tgl@sss.pgh.pa.us>, Andres Freund <andres@anarazel.de>, Pg Hackers <pgsql-hackers@postgresql.org>

Date: 2021-10-01T09:55:37Z

Lists: pgsql-hackers

On Wed, Sep 22, 2021 at 1:12 AM Ranier Vilela <ranier.vf@gmail.com> wrote:
> Anyway, the v1 patch fixes only the expression eval.

The patch looks good to me.

It seems that initially the code looked similar to your patch. See the
commit b8d7f053c5c2bf2a7e8734fe3327f6a8bc711755. Then the variables
were moved to foreach scope by the commit
1ec7679f1b67e84be688a311dce234eeaa1d5de8.

I'll mark the patch as Ready for Commiter.

-- 
Artur

Commits

Fix variable lifespan in ExecInitCoerceToDomain().
- ada667b45496 13.5 landed
- 16a56774fade 14.1 landed
- 01fc6527034a 15.0 landed
expression eval, jit: Minor code cleanups.
- 1ec7679f1b67 13.0 cited
Faster expression evaluation and targetlist projection.
- b8d7f053c5c2 10.0 cited