Re: Add ldapservice connection parameter
Andrew Jackson <andrewjackson947@gmail.com>
From: Andrew Jackson <andrewjackson947@gmail.com>
To: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>,
Roman Khapov <rkhapov@yandex-team.ru>, niushiji@gmail.com, Andrey Borodin <x4mmm@yandex-team.ru>
Date: 2026-04-07T16:20:20Z
Lists: pgsql-hackers
Attachments
- v7-0001-Add-ldapservice-connection-parameter.patch (text/x-patch) patch v7-0001
Hi, > Oh, I didn't look at that. If ldapServiceLookup() already appends a > meaningful error message, there is no need to add another one. Updated patch to only append an error message when rc from ldapServiceLookup is 2. This is the only non zero return of ldapServiceLookup that does not append an error message because it is meant to signal that the lookup was not successful but we can continue parsing the service file. In this case I think it makes sense to raise an error and append an error message. Also increased the specificity of the test assertions. > That change does not really belong to the patch, but is alright by me. I added this because now that there is a connection parameter that begins with ldap it could cause a confusing error message if the user tries to use ldapserviceurl in a service file and are then given an error message that roughly says 'invalid LDAP URL ".*" scheme must be ldap://'. Thanks, Andrew Jackson