Horton

Re: [HACKERS] Runtime Partition Pruning

David Rowley <david.rowley@2ndquadrant.com>

View thread View on postgr.es
From: David Rowley <david.rowley@2ndquadrant.com>
To: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: Rajkumar Raghuwanshi <rajkumar.raghuwanshi@enterprisedb.com>, Beena Emerson <memissemerson@gmail.com>, Alvaro Herrera <alvherre@alvh.no-ip.org>, Robert Haas <robertmhaas@gmail.com>, amul sul <sulamul@gmail.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>, Dilip Kumar <dilipbalaut@gmail.com>
Date: 2018-02-27T09:50:24Z
Lists: pgsql-hackers 
On 27 February 2018 at 22:39, Amit Langote
<Langote_Amit_f8@lab.ntt.co.jp> wrote:
> I've incorporated portions of 0002 and 0003 into my patch on the other
> thread (v34) posted at [1].  That is, mostly the changes around handling
> OR clauses and interface changes resulting from it.

Thanks. I was just in the middle of swapping the order of the patches
so that the OR clause patch was directly based on yours.

> Attached are revised version of your patches after the aforementioned
> rearrangements.  Note that after I took out the optimizer portion of the
> 0003 patch to incorporate it into my patch (OR clause processing bits),
> not much was left in it, so I squashed it into 0002.  So there are only
> 0001 and 0002.

I've locally got a patch which is significantly different to the v12
patch which moves lots of code into nodePartition.c and fixes up the
missing node read/write functions too.

> As a review comment on 0002, I think trypartitionprune is better written
> as try_partition_prune.

That no longer exists in the new version... Will post soonish, just
need to base it all on your v34 [1] now! :)

[1] https://www.postgresql.org/message-id/158f04ce-9deb-0457-ddcc-78fb73db4ebc%40lab.ntt.co.jp

-- 
 David Rowley                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

Commits

  1. Initialize ExprStates once in run-time partition pruning

  2. Add bms_prev_member function

  3. Support partition pruning at execution time

  4. Document partprune.c a little better

  5. Fix crash in pg_replication_slot_advance

  6. Add parallel-aware hash joins.

  7. Fix typo.

  8. Allow --with-bonjour to work with non-macOS implementations of Bonjour.

  9. Mention need for --no-inc-recursive in rsync command