Horton

Re: Bogus lateral-reference-propagation logic in create_lateral_join_info

David Rowley <david.rowley@2ndquadrant.com>

View thread View on postgr.es
From: David Rowley <david.rowley@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2019-02-06T01:26:30Z
Lists: pgsql-hackers 
On Wed, 6 Feb 2019 at 10:57, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Also, I'd really like to know why I had to put in the exception seen
> in the loop for AppendRelInfos that do not point to a valid parent.
> It seems to me that that is almost certainly working around a bug in
> the partitioning logic.  (Without it, the partition_prune regression test
> crashes.)  Or would somebody like to own up to having created that state
> of affairs intentionally?  If so why?

Sounds pretty strange to me.   What exactly do you mean by not
pointing to a valid parent? Do you mean the parent_relid index is not
a valid RelOptInfo?

Can you point to the regression test that's doing this?

-- 
 David Rowley                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

Commits

  1. Propagate lateral-reference information to indirect descendant relations.

  2. Expand partitioned table RTEs level by level, without flattening.