Horton

Re: Custom table AMs need to include heapam.h because of BulkInsertState

David Rowley <david.rowley@2ndquadrant.com>

View thread View on postgr.es
From: David Rowley <david.rowley@2ndquadrant.com>
To: Andres Freund <andres@anarazel.de>
Cc: Michael Paquier <michael@paquier.xyz>, Robert Haas <robertmhaas@gmail.com>, Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2019-08-14T06:11:06Z
Lists: pgsql-hackers

Attachments

On Wed, 17 Jul 2019 at 06:46, Andres Freund <andres@anarazel.de> wrote:
> 2) Add a execPartition.c function that returns all the used tables from
>    a PartitionTupleRouting*.

Here's a patch which implements it that way.

I struggled a bit to think of a good name for the execPartition.c
function. I ended up with ExecGetRoutedToRelations. I'm open to better
ideas.

I also chose to leave the change of function signatures done in
f7c830f1a in place. I don't think the additional now unused parameter
is that out of place. Also, the function is inlined, so removing it
wouldn't help performance any.

-- 
 David Rowley                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

Commits

  1. Fix missing calls to table_finish_bulk_insert during COPY, take 2

  2. Fix missing call to table_finish_bulk_insert during COPY