Re: Suspicious strcmp() in src/backend/parser/parse_expr.c

On Thu, 11 Apr 2019 at 18:51, Michael Paquier <michael@paquier.xyz> wrote:
>
> On Thu, Apr 11, 2019 at 12:55:49AM -0400, Tom Lane wrote:
> > I'd be +1 for that, just on the grounds of having consistent coding
> > style.  But I'm not sufficiently excited about it to do the work
> > myself ...
>
> Well, here you go as per the attached as we are on it.  I am not
> noticing any other spots.

Patch looks fine to me.  I also made a quick pass and noticed a few
more things out of place.

formatting.c in NUM_prepare_locale()

else if (strcmp(Np->decimal, ",") !=0)


spell.c in NISortDictionary()

if (i == 0
|| strcmp(Conf->Spell[i]->p.flag, Conf->Spell[i - 1]->p.flag))

if (i == 0
|| strcmp(Conf->Spell[i]->p.flag, Conf->AffixData[curaffix]))

-- 
 David Rowley                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services