Re: Should we add GUCs to allow partition pruning to be disabled?
David Rowley <david.rowley@2ndquadrant.com>
From: David Rowley <david.rowley@2ndquadrant.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>,
Justin Pryzby <pryzby@telsasoft.com>, Alvaro Herrera <alvherre@2ndquadrant.com>,
Ashutosh Bapat <ashutosh.bapat@enterprisedb.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2019-03-12T23:28:31Z
Lists: pgsql-hackers
Attachments
- docs_partitioning_warning.patch (application/octet-stream) patch
On Wed, 13 Mar 2019 at 04:07, Robert Haas <robertmhaas@gmail.com> wrote: > I think it should be added to one of the existing sub-headings. I > suggest adding it to the end of 5.10.1 and rephrasing it so that it > makes clearer the distinction between what will happen with > inheritance and what will happen with table partitioning, e.g. > > When using either declarative partitioning or table inheritance, > partitioning hierarchies with more than a few hundred partitions are > not currently recommended. Larger partition hierarchies may incur long > planning time, and especially in the case of UPDATE and DELETE, > excessive memory usage. When inheritance is used, see also the > limitations described in Section 5.10.5, Partitioning and Constraint > Exclusion. I think I've done that in the attached patch. However, do think the just saying "excessive memory usage" seems strange without prefixing it with "can result in" and dropping the "especially". I'm fairly used to having my wording debated, so I've left your words in the patch. -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
Commits
-
Tweak partitioning documentation wording
- 12b9affb32a6 11.0 landed
-
docs: Rework sections on partition pruning/exclusion
- bebc46931a12 11.0 landed
-
Add GUC enable_partition_pruning
- 055fb8d33da6 11.0 landed