Re: Small improvement to parallel query docs

David Rowley <david.rowley@2ndquadrant.com>

From: David Rowley <david.rowley@2ndquadrant.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Brad DeJong <Brad.Dejong@infor.com>, Robert Haas <robertmhaas@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2017-02-14T10:17:40Z
Lists: pgsql-hackers

Attachments

On 14 February 2017 at 21:25, Amit Kapila <amit.kapila16@gmail.com> wrote:
> +    Aggregate</> stage. For such cases there is clearly going to be no
> +    performance benefit to using parallel aggregation.
>
> A comma is required after "For such cases"

Added

>> The query planner takes
>> +    this into account during the planning process and will choose how to
>> +    perform the aggregation accordingly.
>
> This part of the sentence sounds unclear.   It doesn't clearly
> indicate that planner won't choose a parallel plan in such cases.

I thought that was obvious enough giving that I'd just mentioned that
there's clearly no benefit, however I've changed things to make that a
bit more explicit.

Thanks for reviewing this.

Updated patch attached.

-- 
 David Rowley                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

Commits

  1. Corrections and improvements to generic parallel query documentation.