Horton

Thread

Commits

  1. Improve postgresql.conf.sample comments about parallel workers.

  1. Small fix to postgresql.conf.sample's comment on max_parallel_workers

    David Rowley <david.rowley@2ndquadrant.com> — 2017-03-07T01:09:06Z

    While scanning over postgresql.conf I happened to notice something
that didn't ring quite true about max_parallel_workers. The comment
confuses worker_processes with parallel workers.

The attached aims to put this right.

-- 
 David Rowley                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

  2. Re: Small fix to postgresql.conf.sample's comment on max_parallel_workers

    Amit Kapila <amit.kapila16@gmail.com> — 2017-03-07T02:21:20Z

    On Tue, Mar 7, 2017 at 6:39 AM, David Rowley
<david.rowley@2ndquadrant.com> wrote:
> While scanning over postgresql.conf I happened to notice something
> that didn't ring quite true about max_parallel_workers. The comment
> confuses worker_processes with parallel workers.
>

+1.  How about changing the description of
max_parallel_workers_per_gather to "taken from max_worker_processes,
limited by max_parallel_workers"?


-- 
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

  3. Re: Small fix to postgresql.conf.sample's comment on max_parallel_workers

    David Rowley <david.rowley@2ndquadrant.com> — 2017-03-07T02:32:24Z

    On 7 March 2017 at 15:21, Amit Kapila <amit.kapila16@gmail.com> wrote:
> +1.  How about changing the description of
> max_parallel_workers_per_gather to "taken from max_worker_processes,
> limited by max_parallel_workers"?

Thanks for looking.

Seems more accurate to say that it's "taken from
max_parallel_workers", maybe. You can't "take" more than what's there,
so perhaps the extra text is not required.

Patch attached.

-- 
 David Rowley                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

  4. Re: Small fix to postgresql.conf.sample's comment on max_parallel_workers

    Amit Kapila <amit.kapila16@gmail.com> — 2017-03-07T12:42:59Z

    On Tue, Mar 7, 2017 at 8:02 AM, David Rowley
<david.rowley@2ndquadrant.com> wrote:
> On 7 March 2017 at 15:21, Amit Kapila <amit.kapila16@gmail.com> wrote:
>> +1.  How about changing the description of
>> max_parallel_workers_per_gather to "taken from max_worker_processes,
>> limited by max_parallel_workers"?
>
> Thanks for looking.
>
> Seems more accurate to say that it's "taken from
> max_parallel_workers", maybe.
>

I thought of saying similar to what we have in docs, however the way
you have written works for me.

-- 
With Regards,
Amit Kapila.
EnterpriseDB: http://www.enterprisedb.com

  5. Re: Small fix to postgresql.conf.sample's comment on max_parallel_workers

    Robert Haas <robertmhaas@gmail.com> — 2017-03-07T20:32:16Z

    On Tue, Mar 7, 2017 at 7:42 AM, Amit Kapila <amit.kapila16@gmail.com> wrote:
> On Tue, Mar 7, 2017 at 8:02 AM, David Rowley
> <david.rowley@2ndquadrant.com> wrote:
>> On 7 March 2017 at 15:21, Amit Kapila <amit.kapila16@gmail.com> wrote:
>>> +1.  How about changing the description of
>>> max_parallel_workers_per_gather to "taken from max_worker_processes,
>>> limited by max_parallel_workers"?
>>
>> Thanks for looking.
>>
>> Seems more accurate to say that it's "taken from
>> max_parallel_workers", maybe.
>>
>
> I thought of saying similar to what we have in docs, however the way
> you have written works for me.

Committed.

-- 
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

  6. Re: Small fix to postgresql.conf.sample's comment on max_parallel_workers

    David Rowley <david.rowley@2ndquadrant.com> — 2017-03-07T21:20:33Z

    On 8 March 2017 at 09:32, Robert Haas <robertmhaas@gmail.com> wrote:
> Committed.

Thanks!

-- 
 David Rowley                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services