Re: Tighten up a few overly lax regexes in pg_dump's tap tests

On Tue, 5 Feb 2019 at 13:15, Michael Paquier <michael@paquier.xyz> wrote:
> Some tests are missing the update, and it seems to me that
> tightening things up is a good thing, still we ought to do it
> consistently.  Some places missing the update:
> - ALTER OPERATOR FAMILY
> - ALTER OPERATOR CLASS
> - ALTER SEQUENCE
> - ALTER TABLE (ONLY, partitioned table)
> - BLOB load
> - COMMENT ON
> - COPY
> - INSERT INTO
> - CREATE COLLATION

I think I've done all the ones that use \E.  Those \Q ones don't need
any escaping. I assume that's the ones you've found.  I didn't do an
exhaustive check though.

> test_pg_dump's 001_base.pl needs also a refresh.

Yeah, I thought about looking, but I thought it might be a bottomless pit.

-- 
 David Rowley                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services