Horton

Thread

Commits

  1. Provide plan_cache_mode options in postgresql.conf.sample.

  1. plan_cache_mode and postgresql.conf.sample

    David Rowley <david.rowley@2ndquadrant.com> — 2018-08-22T05:45:50Z

    Hi,

While testing something that I needed to ensure a generic plan was
being used, during editing postgresql.conf I couldn't quite remember
the exact spelling of the option to do that.  I think the valid
options for the setting should be listed in the sample config file.

Patch attached.

-- 
 David Rowley                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

  2. Re: plan_cache_mode and postgresql.conf.sample

    Thomas Munro <thomas.munro@enterprisedb.com> — 2018-08-22T06:26:52Z

    On Wed, Aug 22, 2018 at 5:45 PM, David Rowley
<david.rowley@2ndquadrant.com> wrote:
> While testing something that I needed to ensure a generic plan was
> being used, during editing postgresql.conf I couldn't quite remember
> the exact spelling of the option to do that.  I think the valid
> options for the setting should be listed in the sample config file.
>
> Patch attached.

Thanks, pushed.  I removed one tab because it looks like the comments
in that file are supposed to line up with tabstop=8 (unlike our source
files which use 4), and this one didn't.  I hope I got that right!

-- 
Thomas Munro
http://www.enterprisedb.com

  3. Re: plan_cache_mode and postgresql.conf.sample

    Michael Paquier <michael@paquier.xyz> — 2018-08-22T06:41:26Z

    On Wed, Aug 22, 2018 at 06:26:52PM +1200, Thomas Munro wrote:
> Thanks, pushed.  I removed one tab because it looks like the comments
> in that file are supposed to line up with tabstop=8 (unlike our source
> files which use 4), and this one didn't.  I hope I got that right!

This line now spawns at 87 characters for me, so that's not quite it.  I
think that you should just have put the list into two lines.
--
Michael

  4. Re: plan_cache_mode and postgresql.conf.sample

    David Rowley <david.rowley@2ndquadrant.com> — 2018-08-22T12:33:30Z

    On 22 August 2018 at 18:41, Michael Paquier <michael@paquier.xyz> wrote:
> On Wed, Aug 22, 2018 at 06:26:52PM +1200, Thomas Munro wrote:
>> Thanks, pushed.  I removed one tab because it looks like the comments
>> in that file are supposed to line up with tabstop=8 (unlike our source
>> files which use 4), and this one didn't.  I hope I got that right!

Thanks for pushing.

I'd failed to notice the 8 char tab stop alignment. Thanks for
removing the additional tab.

> This line now spawns at 87 characters for me, so that's not quite it.  I
> think that you should just have put the list into two lines.

Thomas has now fixed this, but it appears it wasn't the first line to
be guilty of being too long in that file.

-- 
 David Rowley                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

  5. Re: plan_cache_mode and postgresql.conf.sample

    Michael Paquier <michael@paquier.xyz> — 2018-08-23T05:10:17Z

    On Wed, Aug 22, 2018 at 03:41:26PM +0900, Michael Paquier wrote:
> This line now spawns at 87 characters for me, so that's not quite it.  I
> think that you should just have put the list into two lines.

Thanks Thomas for af63926, this addresses the issue.
--
Michael