Re: Further simplification of c.h's #include section

David Rowley <david.rowley@2ndquadrant.com>

From: David Rowley <david.rowley@2ndquadrant.com>
To: Michael Paquier <michael.paquier@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Robert Haas <robertmhaas@gmail.com>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>
Date: 2017-11-16T12:40:44Z
Lists: pgsql-hackers
On 16 November 2017 at 19:14, Michael Paquier <michael.paquier@gmail.com> wrote:
> On Thu, Nov 16, 2017 at 2:23 PM, David Rowley
> <david.rowley@2ndquadrant.com> wrote:
>> I do get some warnings:
>>
>> (ClCompile target) ->
>>   src/test/modules/test_session_hooks/test_session_hooks.c(112): warning
>> C4113: 'void (__cdecl *)()' differs in parameter lists from
>> 'session_start_hook_type' [test_session_hooks.vcxproj]
>>   src/test/modules/test_session_hooks/test_session_hooks.c(113): warning
>> C4113: 'void (__cdecl *)()' differs in parameter lists from
>> 'session_end_hook_type' [test_session_hooks.vcxproj].
>>
>>     2 Warning(s)
>>
>> But I imagine that was caused by 745948422c (also get the warnings without
>> your patch)
>
> Do the warnings go away with the patch attached?

Yes

-- 
 David Rowley                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services


Commits

  1. Further refactoring of c.h and nearby files.

  2. Rearrange c.h to create a "compiler characteristics" section.