Re: executor relation handling

David Rowley <david.rowley@2ndquadrant.com>

From: David Rowley <david.rowley@2ndquadrant.com>

To: Alvaro Herrera <alvherre@2ndquadrant.com>

Cc: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>, Jesper Pedersen <jesper.pedersen@redhat.com>, Amit Langote <amitlangote09@gmail.com>, Pg Hackers <pgsql-hackers@postgresql.org>, Tom Lane <tgl@sss.pgh.pa.us>

Date: 2018-09-29T00:46:36Z

Lists: pgsql-hackers

Attachments

v10-0001-Don-t-lock-range-table-relations-in-the-executor.patch (application/octet-stream) patch v10-0001
v10-0002-Remove-useless-fields-from-planner-nodes.patch (application/octet-stream) patch v10-0002
v10-0003-Prune-PlanRowMark-of-relations-that-are-pruned-f.patch (application/octet-stream) patch v10-0003
v10-0004-Revise-executor-range-table-relation-opening-clo.patch (application/octet-stream) patch v10-0004

On 29 September 2018 at 03:49, Alvaro Herrera <alvherre@2ndquadrant.com> wrote:
> On 2018-Sep-28, Amit Langote wrote:
>> On 2018/09/28 17:48, David Rowley wrote:
>
>> > Meh, I just noticed that the WARNING text claims "InitPlan" is the
>> > function name. I think it's best to get rid of that. It's pretty much
>> > redundant anyway if you do: \set VERBOSITY verbose
>>
>> Oops, good catch that one.  Removed "InitPlan: " from the message in the
>> attached.
>
> Were there two cases of that?  Because one still remains.

Yeah, 0001 added it and 0004 removed it again replacing it with the
corrected version.

I've attached v10 which fixes this and aligns the WARNING text in
ExecInitRangeTable() and addRangeTableEntryForRelation().

-- 
 David Rowley                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

Commits

Avoid O(N^2) cost in ExecFindRowMark().
- f9eb7c14b08d 12.0 landed
Remove some unnecessary fields from Plan trees.
- 52ed730d511b 12.0 landed
Restore sane locking behavior during parallel query.
- 29ef2b310da9 12.0 landed
Remove more redundant relation locking during executor startup.
- f2343653f5b2 12.0 landed
In the executor, use an array of pointers to access the rangetable.
- d73f4c74dd34 12.0 landed
Centralize executor's opening/closing of Relations for rangetable entries.
- 9ddef36278a9 12.0 landed
Change executor to just Assert that table locks were already obtained.
- 9a3cebeaa7fd 12.0 landed
Change rewriter/planner/executor/plancache to depend on RTE rellockmode.
- 6e35939febf8 12.0 landed
Add assertions that we hold some relevant lock during relation open.
- b04aeb0a053e 12.0 landed
Create an RTE field to record the query's lock mode for each relation.
- fdba460a26af 12.0 landed