Re: Switching to 64-bit Bitmapsets

David Rowley <david.rowley@2ndquadrant.com>

From: David Rowley <david.rowley@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2018-12-20T06:44:10Z
Lists: pgsql-hackers

Attachments

On Thu, 20 Dec 2018 at 17:50, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> David Rowley <david.rowley@2ndquadrant.com> writes:
> > However, I doubt it would take much more effort to maintain
> > using 32-bit sets on 32-bit machines.  If someone feels strongly about
> > that then I can adjust the patch to allow that.
>
> Hm, are you thinking of making BITS_PER_BITMAPWORD match sizeof(Pointer)
> or something like that?  That seems like a good compromise from here.

Yeah, something along those lines.  I've implemented that in the attached.

-- 
 David Rowley                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

Commits

  1. Make bitmapset.c use 64-bit bitmap words on 64-bit machines.