Horton

Re: Less than ideal error reporting in pg_stat_statements

David Rowley <david.rowley@2ndquadrant.com>

View thread View on postgr.es
From: David Rowley <david.rowley@2ndquadrant.com>
To: Jim Nasby <Jim.Nasby@bluetreble.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Date: 2015-09-22T22:48:38Z
Lists: pgsql-hackers 
On 23 September 2015 at 10:16, Jim Nasby <Jim.Nasby@bluetreble.com> wrote:

>
>
Attached patch fixes, though I'm not sure if %lld is portable or not.
>
>
I think you could probably use INT64_FORMAT, and cast the stat.st_size to
int64 too.

There's an example in FileRead() in fd.c

Regards

David Rowley

--
 David Rowley                   http://www.2ndQuadrant.com/
<http://www.2ndquadrant.com/>
 PostgreSQL Development, 24x7 Support, Training & Services

Commits

  1. Be more wary about 32-bit integer overflow in pg_stat_statements.