Horton

Re: BUG #15572: Misleading message reported by "Drop function operation" on DB with functions having same name

David Rowley <david.rowley@2ndquadrant.com>

View thread View on postgr.es
From: David Rowley <david.rowley@2ndquadrant.com>
To: Julien Rouhaud <rjuju123@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Michael Paquier <michael@paquier.xyz>, Alvaro Herrera <alvherre@2ndquadrant.com>, Ash M <makmarath@hotmail.com>, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Date: 2019-02-19T20:57:19Z
Lists: pgsql-bugs, pgsql-hackers 
On Wed, 20 Feb 2019 at 09:20, Julien Rouhaud <rjuju123@gmail.com> wrote:
>
> On Tue, Feb 19, 2019 at 9:04 PM David Rowley
> <david.rowley@2ndquadrant.com> wrote:
> > I think since the original argument was a bool then it's pretty
> > unlikely that such an assert would ever catch anything, given 0 and 1
> > are both valid values for this enum type.
>
> Indeed.  It looks all fine to me in v6, so I'm marking the patch as
> ready for committer.

Great. Thanks for reviewing it.


-- 
 David Rowley                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

Commits

  1. Improve error reporting for DROP FUNCTION/PROCEDURE/AGGREGATE/ROUTINE.