Re: Ordered Partitioned Table Scans
David Rowley <david.rowley@2ndquadrant.com>
From: David Rowley <david.rowley@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>, Julien Rouhaud <rjuju123@gmail.com>, Antonin Houska <ah@cybertec.at>,
Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2019-03-24T10:05:58Z
Lists: pgsql-hackers
Attachments
- mergeappend_to_append_conversion_v13.patch (application/octet-stream) patch v13
On Sat, 23 Mar 2019 at 19:42, Tom Lane <tgl@sss.pgh.pa.us> wrote: > > David Rowley <david.rowley@2ndquadrant.com> writes: > > On Sat, 23 Mar 2019 at 05:40, Tom Lane <tgl@sss.pgh.pa.us> wrote: > >> BTW, another thing we could possibly do to answer this objection is to > >> give the ordered-Append node an artificially pessimistic startup cost, > >> such as the sum or the max of its children's startup costs. That's > >> pretty ugly and unprincipled, but maybe it's better than not having the > >> ability to generate the plan shape at all? > > > I admit to having thought of that while trying to get to sleep last > > night, but I was too scared to even suggest it. It's pretty much how > > MergeAppend would cost it anyway. I agree it's not pretty to lie > > about the startup cost, but it does kinda seem silly to fall back on a > > more expensive MergeAppend when we know fine well Append is cheaper. > > Yeah. I'm starting to think that this might actually be the way to go, Here's a version with it done that way. -- David Rowley http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services
Commits
-
Use Append rather than MergeAppend for scanning ordered partitions.
- 959d00e9dbe4 12.0 landed