Re: [GENERAL] Not able to create collation on Windows

Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>

From: Murtuza Zabuawala <murtuza.zabuawala@enterprisedb.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>, PostgreSQL mailing lists <pgsql-general@postgresql.org>, pgsql-hackers@postgresql.org
Date: 2017-08-01T16:33:02Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →
  1. Revert test case added by commit 1e165d05fe06a9072867607886f818bc255507db.

  2. Second try at getting useful errors out of newlocale/_create_locale.

  3. Try to deliver a sane message for _create_locale() failure on Windows.

  4. Allow creation of C/POSIX collations without depending on libc behavior.

Hi Tom,

Yes, I was able to create collation using "C" instead of "POSIX" on windows,

CREATE COLLATION public.test from pg_catalog."C";

--
Regards,
Murtuza Zabuawala

On Tue, Aug 1, 2017 at 9:09 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:

> Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> > On 8/1/17 10:53, Tom Lane wrote:
> >> I think this is actually a bug, because the collations code clearly
> >> means to allow clones of the C/POSIX locales --- see eg lc_collate_is_c,
>
> > You seem to say that we should support a "POSIX" locale even on systems
> > where the C library does not support that.  I'm not convinced about that.
>
> Uh, we already do.  Note all the regression tests that unconditionally
> assume that the POSIX collation works.  Also, I am confused by your
> apparent belief that there might somewhere be a version of libc that
> fails to provide C-locale-compliant behavior.  Surely nobody would
> tolerate a version of strcmp() that fails to act per C spec.
>
>                         regards, tom lane
>